Skip to content

ability to cap rewards granted for deposits at certain percentages #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ability to cap rewards granted for deposits at certain percentages #2371

wants to merge 1 commit into from

Conversation

dbeal-eth
Copy link
Contributor

No description provided.

@dbeal-eth dbeal-eth requested a review from noisekit March 27, 2025 09:58
@dbeal-eth dbeal-eth self-assigned this Mar 27, 2025
noisekit
noisekit approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@noisekit noisekit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we can simplify it to only have one cap and not an array, but other than that - looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@noisekit noisekit noisekit approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@dbeal-eth dbeal-eth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dbeal-eth @noisekit